Remove .NET Core 2.1.x and 3.1.x from build SDK setup by ITaluone · Pull Request #2467 · fluentassertions/fluentassertions · GitHub
Skip to content

Remove .NET Core 2.1.x and 3.1.x from build SDK setup#2467

Merged
dennisdoomen merged 1 commit into
fluentassertions:developfrom
ITaluone:remove-net-sdk-setup
Nov 16, 2023
Merged

Remove .NET Core 2.1.x and 3.1.x from build SDK setup#2467
dennisdoomen merged 1 commit into
fluentassertions:developfrom
ITaluone:remove-net-sdk-setup

Conversation

@ITaluone

Copy link
Copy Markdown
Contributor

Since we do not support .NET Core 2.1.x and 3.1.x anymore nor test against this TFMs I think we don't need to set them up in the build pipline.

IMPORTANT

  • If the PR touches the public API, the changes have been approved in a separate issue with the "api-approved" label.
  • The code complies with the Coding Guidelines for C#.
  • The changes are covered by unit tests which follow the Arrange-Act-Assert syntax and the naming conventions such as is used in these tests.
  • If the PR adds a feature or fixes a bug, please update the release notes with a functional description that explains what the change means to consumers of this library, which are published on the website.
  • If the PR changes the public API the changes needs to be included by running AcceptApiChanges.ps1 or AcceptApiChanges.sh.
  • If the PR affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
    • Please also run ./build.sh --target spellcheck or .\build.ps1 --target spellcheck before pushing and check the good outcome

@github-actions

Copy link
Copy Markdown

@coveralls

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 6887736004

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.457%

Totals Coverage Status
Change from base Build 6887225049: 0.0%
Covered Lines: 11743
Relevant Lines: 11926

💛 - Coveralls

@dennisdoomen dennisdoomen merged commit 95010ce into fluentassertions:develop Nov 16, 2023
@ITaluone ITaluone deleted the remove-net-sdk-setup branch November 16, 2023 11:06
jnyrup pushed a commit to jnyrup/fluentassertions that referenced this pull request Dec 19, 2024
jnyrup pushed a commit to jnyrup/fluentassertions that referenced this pull request Feb 1, 2025
ScarletKuro referenced this pull request in AwesomeAssertions/AwesomeAssertions Feb 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants