Avoid possible 'null' assignment in `CallerIdentifier` by vbreuss · Pull Request #2448 · fluentassertions/fluentassertions · GitHub
Skip to content

Avoid possible 'null' assignment in CallerIdentifier#2448

Merged
jnyrup merged 2 commits into
fluentassertions:developfrom
vbreuss:topic/fix-resharper-issues
Nov 17, 2023
Merged

Avoid possible 'null' assignment in CallerIdentifier#2448
jnyrup merged 2 commits into
fluentassertions:developfrom
vbreuss:topic/fix-resharper-issues

Conversation

@vbreuss

@vbreuss vbreuss commented Nov 9, 2023

Copy link
Copy Markdown
Contributor

Fix issue detected by ReSharper:

  • Possible 'null' assignment to non-nullable entity

IMPORTANT

  • If the PR touches the public API, the changes have been approved in a separate issue with the "api-approved" label.
  • The code complies with the Coding Guidelines for C#.
  • The changes are covered by unit tests which follow the Arrange-Act-Assert syntax and the naming conventions such as is used in these tests.
  • If the PR adds a feature or fixes a bug, please update the release notes with a functional description that explains what the change means to consumers of this library, which are published on the website.
  • If the PR changes the public API the changes needs to be included by running AcceptApiChanges.ps1 or AcceptApiChanges.sh.
  • If the PR affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
    • Please also run ./build.sh --target spellcheck or .\build.ps1 --target spellcheck before pushing and check the good outcome

@github-actions

github-actions Bot commented Nov 9, 2023

Copy link
Copy Markdown

@coveralls

coveralls commented Nov 9, 2023

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 6823042175

  • 7 of 7 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 97.462%

Totals Coverage Status
Change from base Build 6801258828: 0.02%
Covered Lines: 11739
Relevant Lines: 11924

💛 - Coveralls

@dennisdoomen dennisdoomen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙃 (nitpick) I'd prefer more functional commit titles.

Comment thread Src/FluentAssertions/CallerIdentifier.cs Outdated
@dennisdoomen dennisdoomen requested a review from jnyrup November 9, 2023 09:46
@vbreuss

vbreuss commented Nov 9, 2023

Copy link
Copy Markdown
Contributor Author

🙃 (nitpick) I'd prefer more functional commit titles.

I split the pull request in two. This one now only updates the CallerIdentifier and the consolidation of namespace and file location is moved to #2449.

@vbreuss vbreuss changed the title Fix ReSharper issues Avoid possible 'null' assignment in CallerIdentifier Nov 9, 2023
@dennisdoomen

Copy link
Copy Markdown
Member

I split the pull request in two. This one now only updates the CallerIdentifier and the consolidation of namespace and file location is moved to #2449.

It could have been two separate commits. But all commits and PR titles need to be as functional as possible.

Comment thread Src/FluentAssertions/CallerIdentifier.cs
@dennisdoomen

Copy link
Copy Markdown
Member

What about the Qodana issues?

@vbreuss

vbreuss commented Nov 17, 2023

Copy link
Copy Markdown
Contributor Author

@jnyrup jnyrup merged commit 4dc9e5d into fluentassertions:develop Nov 17, 2023
@vbreuss vbreuss deleted the topic/fix-resharper-issues branch November 17, 2023 12:34
jnyrup pushed a commit to jnyrup/fluentassertions that referenced this pull request Jul 14, 2024
…ons#2448)

* Fix "Possible 'null' assignment to non-nullable entity"

* Add null check only when not NET6 or greater
jnyrup pushed a commit to jnyrup/fluentassertions that referenced this pull request Jul 14, 2024
…ons#2448)

* Fix "Possible 'null' assignment to non-nullable entity"

* Add null check only when not NET6 or greater
jnyrup pushed a commit to jnyrup/fluentassertions that referenced this pull request Jul 14, 2024
…ons#2448)

* Fix "Possible 'null' assignment to non-nullable entity"

* Add null check only when not NET6 or greater
jnyrup pushed a commit to jnyrup/fluentassertions that referenced this pull request Aug 18, 2024
…ons#2448)

* Fix "Possible 'null' assignment to non-nullable entity"

* Add null check only when not NET6 or greater
jnyrup pushed a commit to jnyrup/fluentassertions that referenced this pull request Aug 18, 2024
…ons#2448)

* Fix "Possible 'null' assignment to non-nullable entity"

* Add null check only when not NET6 or greater
jnyrup pushed a commit to jnyrup/fluentassertions that referenced this pull request Aug 24, 2024
…ons#2448)

* Fix "Possible 'null' assignment to non-nullable entity"

* Add null check only when not NET6 or greater
jnyrup pushed a commit that referenced this pull request Sep 9, 2024
* Fix "Possible 'null' assignment to non-nullable entity"

* Add null check only when not NET6 or greater
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants