Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

      - name: 'Qodana Scan'
        uses: JetBrains/qodana-action@v2023.2.6
        with:
          upload-result: true

Out of curiosity:

Should this test fail or pass?

[Fact]
public void A_enumerable_of_key_value_pairs_and_generic_dict()
{
    var subject = new List<KeyValuePair<string, object>>
    {
        new("id", 22),
        new("CustomerId", 33)
    };

    var expected = new Dictionary<object, object>
    {
        ["id"] = 22,
        ["CustomerId"] = 33
    };

    subject.Should().BeEquivalentTo(expected);
}

Edit: Oh.. it does 🙈 (with KeyValuePair<object, object>)...

Pull Request Test Coverage Report for Build 6472389490

• 21 of 21 (100.0%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.02%) to 97.402%

Totals
Change from base Build 6464892225:	0.02%
Covered Lines:	11655
Relevant Lines:	11846

💛 - Coveralls

The very first two commits are to fix the actual problem. Commit 3-6 are for code quality (and therefore can moved to a separate PR if needed).

It's totally fine to combine the fix and the refactorings in a single PR. But that requires you to ensure that every commit has a clear purpose so that we can review them one by one and we can rebase-merge them. But in your case, it looks like some commits are rework on earlier commits. Same for the "release notes" commit.

But that requires you to ensure that every commit has a clear purpose so that we can review them one by one and we can rebase-merge them. But in your case, it looks like some commits are rework on earlier commits. Same for the "release notes" commit.

How can a refactoring commit be a "non-rework" of previous commits? 🤔

@dennisdoomen I have combined all commits to one, because I had no clue, how I could add refactoring commits, but not interfere (or non-rework) with changes in previous commits.

Sorry :/

But I am happy if you could point me into the correct direction (for PRs in future)

Using fixup commits and interactive squashing. See https://www.continuousimprover.com/2020/03/keep-source-control-history-clean.html

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

      - name: 'Qodana Scan'
        uses: JetBrains/qodana-action@v2023.2.8
        with:
          upload-result: true