Repository navigation
refactor: split FluentD and FluentBit into 2 projects - #3
Conversation
Signed-off-by: ahmadqasembader <ahmadbader245@gmail.com>
ahmadqasembader
added
help wanted
There was a problem hiding this comment.
slack_channels - name field is set to "#fluent-bit", it should be "#fluentd".
There was a problem hiding this comment.
Thanks for catching it. Done.
Can you take a look at the other TODOs in the file please. They need the project maintainers attention. Thanks
Updated Slack channel name from '#fluent-bit' to '#fluentd'.
There was a problem hiding this comment.
Should we include maintainers for this as well, e.g. @eschabell?
There was a problem hiding this comment.
@patrick-stephens @edsiper I thought all the work I do was maintainers work...
Signed-off-by: ahmadqasembader <ahmadbader245@gmail.com>
Signed-off-by: ahmadqasembader <ahmadbader245@gmail.com>
|
I addressed your comments, @patrick-stephens. Thanks. There are still fields with |
Co-authored-by: Pat <patrick.j.k.stephens@gmail.com>
|
Can you please merge this if everything looks good? @patrick-stephens |
|
@ahmadqasembader thanks for this. Since we will need to do some adjustments at least on Fluent bit side, where we can learn from best practices or the guide to have things in sync ? |
|
@edsiper For details and niche questions, you can reach out to us on Slack - If that doesn't work, you can create an issue in |
ref: #1