{{ message }}
docs: Add documentation for FlatRun UI#73
Open
Lantum-Brendan wants to merge 5 commits into
Open
Conversation
![sourceant[bot]](https://avatars.githubusercontent.com/in/1161781?s=60&v=4){kind=small}
| try_files $uri $uri/ /index.html; | ||
| } | ||
|
|
||
| location /api { |
There was a problem hiding this comment.
The Nginx configuration for /api is missing the rewrite directive if the backend agent doesn't expect the /api prefix, or it may need trailing slash consistency. Also, proxy_set_header X-Forwarded-For is a standard best practice for identifying the client IP through proxies.
Suggested change
| location /api { | |
| location /api/ { | |
| proxy_pass http://localhost:8090/; | |
| proxy_set_header Host $host; | |
| proxy_set_header X-Real-IP $remote_addr; | |
| proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for; | |
| } |
| ### Docker Deployment | ||
|
|
||
| ```dockerfile | ||
| FROM nginx:alpine |
There was a problem hiding this comment.
The Dockerfile relies on a local dist/ folder and a nginx.conf that might not exist in the root. It is safer to suggest a multi-stage build to ensure the build environment is consistent and doesn't depend on the host machine's state.
Suggested change
kofimokome
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add docs.json manifest and 4 markdown files covering overview, development setup, connecting to agent, and production deployment.