{{ message }}
Feat: Add YAML validation for compose content in deployment flows#46
Open
austin047 wants to merge 2 commits into
Open
Feat: Add YAML validation for compose content in deployment flows#46austin047 wants to merge 2 commits into
austin047 wants to merge 2 commits into
Conversation
![sourceant[bot]](https://avatars.githubusercontent.com/in/1161781?s=60&v=4){kind=small}
| return { valid: false, error: "Compose content is empty" }; | ||
| } | ||
| try { | ||
| parse(trimmed); |
There was a problem hiding this comment.
By default, the yaml package's parse function might only throw for critical syntax errors. For stricter validation (e.g., catching duplicate keys which are common in Compose files), it is better to check for warnings or use a stricter parsing configuration if available in the version installed.
Suggested change
| parse(trimmed); | |
| parse(trimmed, { uniqueKeys: true }); |
| @@ -1 +1 @@ | |||
| VITE_API_URL=http://localhost:8080 | |||
There was a problem hiding this comment.
The API URL has been changed from port 8080 to 8090 and appended with /api. Ensure this change is intentional for the example environment and matched in server-side configurations.
Suggested change
| VITE_API_URL=http://localhost:8080 | |
| VITE_API_URL=http://localhost:8090/api |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.