{{ message }}
support more possible inputs for relay key config#703
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for BIP44-compatible inputs for relay secret key configuration by updating the key parsing logic to accept various input formats including mnemonic seed phrase outputs.
- Updated the secret key parsing logic to use hex decoding and bytes-based key creation
- Added hex module import to support the new decoding functionality
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Comment on lines
+324
to
+325
There was a problem hiding this comment.
The change from SecretKey::try_from(resolved_key)? to hex decoding breaks backward compatibility with existing non-hex secret key formats. The original code likely supported multiple input formats, but this change forces all inputs to be hex-encoded. Consider adding format detection or maintaining support for the original format alongside hex decoding.
Suggested change
barnabasbusa
approved these changes
Sep 5, 2025
metachris
approved these changes
Sep 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the relay secret key configuration option was not compatible with BIP44 input, e.g. the output of a mnemonic seed phrase and a given path in the tree
this PR now supports this feature which was simplest by just exposing a BIP44 compatible API the underlying ethereum-consensus dependency
✅ I have completed the following steps:
make lintmake test