{{ message }}
docs(test-suite): fix broken CONTRIBUTING.md relative link - #4474
Open
feizhuzheng wants to merge 1 commit into
Open
docs(test-suite): fix broken CONTRIBUTING.md relative link#4474feizhuzheng wants to merge 1 commit into
feizhuzheng wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Problem
apps/test-suite/README.mdlinks to the project's main contributing guide with a single-dot-dot relative path:From
apps/test-suite/,../CONTRIBUTING.mdresolves toapps/CONTRIBUTING.md, which does not exist. The onlyCONTRIBUTING.mdin the repo lives at the root, so the link 404s on GitHub (and anywhere the README is rendered relative to its own path).Fix
Point the link one more level up so it reaches the root file:
The surrounding sentence already says "the project's main CONTRIBUTING.md", so the intended target is unambiguously the root file.
How to verify
From the repo root:
Or open
apps/test-suite/README.mdon GitHub and click the link before/after:../CONTRIBUTING.md404s,../../CONTRIBUTING.mdlands on the root guide.Docs-only, one line changed.
Summary by cubic
Fixes the broken relative link in
apps/test-suite/README.mdso it points to the rootCONTRIBUTING.mdinstead of the non-existentapps/CONTRIBUTING.md.Written for commit 77167dd. Summary will update on new commits.