FCM quick start app update to use new FCM v1 registration api(s)#2810
FCM quick start app update to use new FCM v1 registration api(s)#2810eldhosembabu wants to merge 2 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the FCM quickstart sample to use the new FCM Registration API (using Installation ID) instead of the deprecated registration token, upgrading the Firebase BoM and replacing getToken and onNewToken with register, onRegistered, and onUnregistered in both Java and Kotlin implementations. The review feedback highlights critical issues: calling Toast.makeText directly inside the background-threaded onRegistered callback will cause a crash and must be posted to the main thread. Additionally, several mismatched documentation tags (such as duplicate onRegistered tags and outdated log_reg_token end tags) need correction, and the button text in the layout should be updated to reflect the new registration functionality.
There was a problem hiding this comment.
Enable FCM New FCM Registration using Installation id
nit: should this be a variable name with '_' delimiter such as fcm_installation_id_enabled?
2 participants
FCM quick start app update to use new FCM v1 registration api(s)