fix: fix pyproject.toml to include all packages. by taeold · Pull Request #254 · firebase/firebase-functions-python · GitHub
Skip to content

fix: fix pyproject.toml to include all packages.#254

Merged
taeold merged 1 commit intomainfrom
dl-fix-build
Oct 17, 2025
Merged

fix: fix pyproject.toml to include all packages.#254
taeold merged 1 commit intomainfrom
dl-fix-build

Conversation

@taeold
Copy link
Copy Markdown
Collaborator

@taeold taeold commented Oct 17, 2025

Formatter is causing some churn, but the real diff is:

[tool.setuptools]
package-dir = { "" = "src" }
[tool.setuptools.packages.find]
where = ["src"]

to make sure that we include all subpackages (e.g. firebase_functions/private and firebase_functions/alerts) in the built package.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request modifies the pyproject.toml file to ensure all subpackages are included in the built package. The changes involve updating the [tool.setuptools] section to use packages.find instead of explicitly listing packages, and some formatting adjustments. I have provided feedback focusing on code correctness and highlighting a potential issue with the ruff configuration.

Comment thread pyproject.toml
Comment thread pyproject.toml
Comment thread pyproject.toml
Copy link
Copy Markdown
Contributor

@jhuleatt jhuleatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we add a check to the build script to ensure all packages are there?

@taeold
Copy link
Copy Markdown
Collaborator Author

taeold commented Oct 17, 2025

@taeold taeold merged commit 2da4c36 into main Oct 17, 2025
11 checks passed
@github-project-automation github-project-automation Bot moved this from Approved [PR] to Done in [Cloud] Extensions + Functions Oct 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants