{{ message }}
fix: fix pyproject.toml to include all packages.#254
Merged
Conversation
Contributor
Contributor
There was a problem hiding this comment.
Code Review
The pull request modifies the pyproject.toml file to ensure all subpackages are included in the built package. The changes involve updating the [tool.setuptools] section to use packages.find instead of explicitly listing packages, and some formatting adjustments. I have provided feedback focusing on code correctness and highlighting a potential issue with the ruff configuration.
jhuleatt
approved these changes
Oct 17, 2025
Contributor
jhuleatt
left a comment
There was a problem hiding this comment.
could we add a check to the build script to ensure all packages are there?
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Formatter is causing some churn, but the real diff is:
to make sure that we include all subpackages (e.g.
firebase_functions/privateandfirebase_functions/alerts) in the built package.