{{ message }}
fix: precision timestamp detection issue#137
Merged
taeold merged 3 commits intofirebase:mainfrom Oct 3, 2023
Merged
Conversation
Contributor
Contributor
Author
|
@exaby73 yes I believe I clicked "allow edits from maintainers" so you should be able to modify freely. But more than that, I think this issue requires coordination with the firebase-tools maintainers. They released a new version which was not backwards compatible with firebase-functions-python. There's not any testing to be done on the FFP side that will prevent such mistakes in the future. That will have to come from the firebase-tools folks, if they care to make releases backwards compatible with other parts of the FireBase ecosystem. |
Contributor
|
Could you link the PR which added these non-backwards compatible changes so that I may have a look? |
taeold
approved these changes
Sep 25, 2023
Contributor
Author
exaby73
approved these changes
Oct 3, 2023
Salakar
changed the title
Salakar
approved these changes
Oct 3, 2023
taeold
approved these changes
Oct 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#136