{{ message }}
handle more iterable types for messaging tokens - #977
Open
pawel-steto wants to merge 1 commit into
Open
pawel-steto wants to merge 1 commit into
pawel-steto wants to merge 1 commit into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request relaxes type checks in check_string_list and check_number_list from list to Iterable (excluding str and dict) to support other iterable types like tuples and sets, with corresponding test updates. The reviewer noted that using Iterable allows generators or iterators, which can be exhausted during validation and will raise a TypeError when len() is called. The reviewer suggested using Collection instead of Iterable to ensure the input is sized and can be safely iterated multiple times.
pawel-steto
force-pushed
the
pawe/allow-iterable-tokens
branch
from
August 21, 2026 09:57
b65857f to
410ccb1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The messaging tokens could only be a python
listThis PR allows to pass tuples, sets, or event django querysets.