{{ message }}
Support FIREBASE_TENANT_EMULATOR_HOST in TenantManagementService - #962
Open
KetanHegde wants to merge 3 commits into
Open
KetanHegde wants to merge 3 commits into
KetanHegde wants to merge 3 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces support for the Firebase Tenant Emulator by checking the FIREBASE_TENANT_EMULATOR_HOST environment variable and configuring the tenant management service to use the emulator host and credentials when available. The tests have also been updated to run in both emulated and non-emulated modes. Feedback on this PR suggests falling back to the standard FIREBASE_AUTH_EMULATOR_HOST if the tenant-specific emulator host is not set, ensuring a smoother developer experience when running the local Auth emulator.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for running
TenantManagementServiceagainst the Firebase Authentication Emulator using a new environment variable,FIREBASE_TENANT_EMULATOR_HOST.When this environment variable is set,
_TenantManagementServiceuses the emulator endpoint instead of the production Identity Toolkit endpoint and initializes the client withEmulatorAdminCredentials.Changes
FIREBASE_TENANT_EMULATOR_HOSTget_tenant_emulator_host()helper_TenantManagementServiceto use the emulator endpoint when configuredTesting
Executed:
Result:
Also verified with:
The remaining pylint warnings are pre-existing in the test module.
Implements #910