feat(fcm): Add support for bandwidth constrained and restricted satellite APIs by jonathanedey · Pull Request #940 · firebase/firebase-admin-python · GitHub
Skip to content

feat(fcm): Add support for bandwidth constrained and restricted satellite APIs#940

Merged
jonathanedey merged 2 commits into
mainfrom
je-satellite-apis
Mar 12, 2026
Merged

feat(fcm): Add support for bandwidth constrained and restricted satellite APIs#940
jonathanedey merged 2 commits into
mainfrom
je-satellite-apis

Conversation

@jonathanedey

Copy link
Copy Markdown
Contributor

This change adds the bandwidth_constrained_ok and restricted_satellite_ok options to the AndroidConfig object. This gives developers granular control over message delivery when an Android device is operating under restricted network conditions, such as Data Saver mode or an active satellite network connection.

@jonathanedey jonathanedey added the release:stage Stage a release candidate label Mar 2, 2026
@gemini-code-assist

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for bandwidth_constrained_ok and restricted_satellite_ok to the AndroidConfig object. The changes are correctly implemented in the data model, encoder, and tests, following the existing patterns for similar boolean fields. My review includes one suggestion to refactor the new tests to reduce code duplication and improve maintainability.

Comment thread tests/test_messaging.py

@lahirumaramba lahirumaramba left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Comment thread firebase_admin/_messaging_utils.py Outdated
@jonathanedey jonathanedey merged commit d62a15e into main Mar 12, 2026
14 checks passed
@jonathanedey jonathanedey deleted the je-satellite-apis branch March 12, 2026 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release:stage Stage a release candidate release-note

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants