{{ message }}
feat(functions): Enable Cloud Task Queue Emulator support#920
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces support for the Cloud Task Queue Emulator, which is a valuable addition for local development and testing. The implementation correctly detects the emulator environment and adapts the API requests. The refactoring to use _to_api_dict for payload creation is a nice improvement for clarity and correctness. I have identified a couple of issues: a potential runtime error when parsing the emulator's response, and a missing input validation in the delete method which appears to be a regression. I've also suggested a small performance optimization to cache the environment variable lookup. Overall, this is a solid contribution with comprehensive tests for the new functionality.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows the admin SDK to enqueue and delete tasks within the locally running cloud tasks emulator to provide for easier testing.
RELEASE NOTES: Enabled support for interacting with the Cloud Task emulator when the
CLOUD_TASKS_EMULATOR_HOSTenvironment variable is set.