{{ message }}
Repository navigation
Record feature deletions in global history - #200
Merged
Merged
Conversation
- Flatten Rollout#delete; built-in adapters receive event: nil when global logging is off, keeping the legacy fallback for older adapters. - Redis: replace the Lua script with plain commands, using DEL's return value as the existence check. Matches the adapter's existing consistency model and avoids CROSSSLOT on Redis Cluster. - Active Record: detect existence via delete_all instead of lock + load. - Split the combined core spec, drop the stubbed transaction spec, and assert registry removal in the history contract. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
delete_feature_with_history(name, event:, history_length:);eventisnilwhen global logging is off or suppressed.DEL's return value decides whether the feature existed, so concurrent deletes record one event. Like the adapter's other writes, the steps are not atomic as a group; this keeps it Redis Cluster–safe.delete_feature_with_historykeep the previous deletion behavior (no event), since rollout 3.1 is released and adapter gems version independently. The fallback can be dropped in 4.0.Testing
feature_state_specBigDecimal on Ruby 3.4 (pre-existing,bigdecimalnot a default gem).🤖 Generated with Claude Code