Adhoc prepare by gz · Pull Request #6095 · feldera/feldera · GitHub
Skip to content

Adhoc prepare#6095

Merged
gz merged 3 commits intomainfrom
adhoc-prepare
Apr 22, 2026
Merged

Adhoc prepare#6095
gz merged 3 commits intomainfrom
adhoc-prepare

Conversation

@gz
Copy link
Copy Markdown
Contributor

@gz gz commented Apr 22, 2026

Fixes #6093

Describe Manual Test Plan

Ran some test pipelines

Checklist

  • Unit tests added/updated
  • Documentation updated

Breaking Changes?

No.

gz added 2 commits April 21, 2026 21:21
Signed-off-by: Gerd Zellweger <mail@gerdzellweger.com>
This adds support for queries in the form of

```
prepare stmt1; prepare stmt2; stmt3;
```

e.g.,

```
PREPARE p AS SELECT $1 AS x; EXECUTE p(42)
```

The session that stores the prepared statements is per
HTTP session. Since websockets currently close the connection
after a query, even websockets do not persist query state within
a session. But we may relax this in the future and not close the
socket after a single query when a websocket is opened.

Signed-off-by: Gerd Zellweger <mail@gerdzellweger.com>
@gz gz requested a review from mihaibudiu April 22, 2026 04:54
Comment thread crates/adapters/src/adhoc.rs
@mihaibudiu
Copy link
Copy Markdown
Contributor

Signed-off-by: Gerd Zellweger <mail@gerdzellweger.com>
@gz gz force-pushed the adhoc-prepare branch from d53af7e to 87f1125 Compare April 22, 2026 05:10
@gz gz enabled auto-merge April 22, 2026 05:10
@gz gz added this pull request to the merge queue Apr 22, 2026
Copy link
Copy Markdown

@mythical-fred mythical-fred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — typo in first commit subject: "statemnts" → "statements".

Merged via the queue into main with commit 0626c6b Apr 22, 2026
1 check passed
@gz gz deleted the adhoc-prepare branch April 22, 2026 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[adhoc] cannot execute PREPARE queries

3 participants