pipeline-manager: fix refreshing of details by snkas · Pull Request #6080 · feldera/feldera · GitHub
Skip to content

pipeline-manager: fix refreshing of details#6080

Merged
snkas merged 1 commit intomainfrom
fix-storage-status-details-refresh
Apr 20, 2026
Merged

pipeline-manager: fix refreshing of details#6080
snkas merged 1 commit intomainfrom
fix-storage-status-details-refresh

Conversation

@snkas
Copy link
Copy Markdown
Contributor

@snkas snkas commented Apr 20, 2026

  • The minimum update interval (10s) now applies to any of the three details (resources, runtime and status), rather than only on resources details.
  • As a tradeoff, there is some additional latency before they will be reported (at most 10 seconds).
  • Fix: the previous storage status details are now correctly updated, such that only when they change it triggers an update in the database instead of upon every check. Python regression test is included for this.

Copy link
Copy Markdown
Contributor

@mihaibudiu mihaibudiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really see how the commit message describes this change, maybe the commit message should become a comment on this statement?

@snkas snkas force-pushed the fix-storage-status-details-refresh branch 2 times, most recently from 1cc543f to 62b84c0 Compare April 20, 2026 18:08
@snkas snkas changed the title pipeline-manager: fix refreshing of storage status details pipeline-manager: fix refreshing of details Apr 20, 2026
@snkas
Copy link
Copy Markdown
Contributor Author

snkas commented Apr 20, 2026

- The minimum update interval (10s) now applies to any of the three
  details (resources, runtime and status), rather than only on resources
  details.
- As a tradeoff, there is some additional latency before they will be
  reported (at most 10 seconds).
- Fix: the previous storage status details are now correctly updated,
  such that only when they change it triggers an update in the database
  instead of upon every check. Python regression test is included for
  this.

Signed-off-by: Simon Kassing <simon.kassing@feldera.com>
@snkas snkas force-pushed the fix-storage-status-details-refresh branch from 62b84c0 to 1d9880f Compare April 20, 2026 18:11
@snkas
Copy link
Copy Markdown
Contributor Author

snkas commented Apr 20, 2026

@snkas snkas added this pull request to the merge queue Apr 20, 2026
Copy link
Copy Markdown

@mythical-fred mythical-fred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Merged via the queue into main with commit 15066fe Apr 20, 2026
40 checks passed
@snkas snkas deleted the fix-storage-status-details-refresh branch April 20, 2026 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants