iframe-proxy

Karakatiza666 · 2026-04-17T13:38:22Z

Fork an upstream vite plugin to fix a bug

mythical-fred

LGTM

mihaibudiu

Cannot tell if some case has been omitted, but the implemented ones look fine.

mihaibudiu · 2026-04-17T17:50:39Z

+    "check": "tsc --noEmit"
+  },
+  "license": "AGPL-3.0-or-later",
+  "description": "Fork of @bithero/monaco-editor-vite-plugin with a bug fix for the optimizeDeps.include filter (original kept only 'monaco-editor' and dropped everything else).",


Is there an issue about this bug? Do we plan to switch back to the other plugin eventually?
If you have a fix, have you contributed it?

I have not found a way to contribute directly; the sorce seems to be private, I would need to reach the author on Bluesky where I don't have an account yet

mihaibudiu · 2026-04-17T17:57:20Z

        if (
-          tA.row < visible.min || tA.row > visible.max ||
-          tF.row < visible.min || tF.row > visible.max
+          tA.row < visible.min ||


some tools really like reformatting every time you run them

mihaibudiu · 2026-04-17T18:00:07Z

    update,
-    onNotFound: () => goto(resolve(`/`))
+    getDeleted: () => deleted,
+    onNotFound: () => {


I hope that this cannot happen when you have problems talking to the manager, just when the manager gives you a list which does not include this pipeline

That's right; onNotFound can only be called when the pipeline currently being inspected is either not in the pipelines list, or was not found by the name (not a generic request failure) - both mean exactly the same - the pipeline was either deleted or renamed out-of-band

mihaibudiu · 2026-04-17T18:01:24Z

-git checkout origin/claude-context -- $FILES
-git restore --staged $FILES
-echo "✅ Pulled Claude context files from claude-context branch."
+REPO_ROOT=$(git rev-parse --show-toplevel)


I am not reviewing this file

mihaibudiu · 2026-04-17T18:02:23Z

@@ -0,0 +1,232 @@
+// @feldera/monaco-editor-vite-plugin — Vite plugin to include & bundle monaco-editor.


I am not reviewing these files

mihaibudiu · 2026-04-17T18:05:10Z

  })
 }

+export const getPipelineThumb = async (


I understand what "status" is, but what is "thumb?"

That's a naming convention I use in web-console for limited pipeline info, generally retrieved with ?selector=status - a set of information that serves as a "preview" of the pipeline. I derived it from the word "thumbnail".

mihaibudiu · 2026-04-17T18:05:36Z

-      ...options
-    }),
-    (pipeline) =>
-      consolidatePipelineStatus(


where did this one go?

Previously this function used the getPipeline endpoint with selector: 'status' which provides a bunch of info about a pipeline, but only returned pipeline's runtime status. I replaced this function with the one that returns all the retrieved fields, not just the status (getPipelineThumb).

mihaibudiu · 2026-04-17T18:06:17Z

 * (Playwright-specific), falling back to `http://localhost:8080`.
 */
 export function configureTestClient() {
+  // In browser tests (vitest with browser mode), `process` is undefined — fall


what is process?

process is a well-known standard global variable name which is usually set when the JavaScript code is run in the server environment - e.g. with Node.js runtime or others. When JavaScript is executed in the browser this variable is not defined; FYI instead the main variable that is set is window.

mihaibudiu · 2026-04-17T18:14:04Z

@@ -0,0 +1,61 @@
+import { expect, test } from '@playwright/test'


why is the file named e2e?

A naming convention for end-to-end UI tests - that imply testing the full web-console build, rendered in a real browser engine, talking to the pipeline-manager instance

mihaibudiu · 2026-04-17T18:16:29Z

+    await deletePipeline(PIPELINE_A)
+
+    // The page should enter the frozen "Deleted" state.
+    await expect(statusChip).toHaveText(/deleted/i, { timeout: 10_000 })


so toHaveText does polling until this timeout happens or the condition is true?

Fork an upstream vite plugin to fix a bug Signed-off-by: Karakatiza666 <bulakh.96@gmail.com>

Karakatiza666 requested a review from mihaibudiu April 17, 2026 13:38

mythical-fred approved these changes Apr 17, 2026

View reviewed changes

mihaibudiu approved these changes Apr 17, 2026

View reviewed changes

Karakatiza666 force-pushed the ui-2 branch from 5947439 to 68f1215 Compare April 20, 2026 14:04

Karakatiza666 enabled auto-merge April 20, 2026 14:05

Karakatiza666 force-pushed the ui-2 branch from 5947439 to 68f1215 Compare April 20, 2026 14:05

[web-console] Implement read-only view for a deleted pipeline

5f300db

Fork an upstream vite plugin to fix a bug Signed-off-by: Karakatiza666 <bulakh.96@gmail.com>

Karakatiza666 force-pushed the ui-2 branch from 68f1215 to 5f300db Compare April 20, 2026 18:26

Karakatiza666 added this pull request to the merge queue Apr 20, 2026

Merged via the queue into main with commit dce6799 Apr 21, 2026
1 check passed

Karakatiza666 deleted the ui-2 branch April 21, 2026 03:48

		@@ -0,0 +1,232 @@
		// @feldera/monaco-editor-vite-plugin — Vite plugin to include & bundle monaco-editor.

		@@ -0,0 +1,61 @@
		import { expect, test } from '@playwright/test'

Sunbelt Computer Software

PL/B Language Development and Support

Conversation

Karakatiza666 commented Apr 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mythical-fred left a comment

Choose a reason for hiding this comment

Uh oh!

mihaibudiu left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Karakatiza666 Apr 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Karakatiza666 commented Apr 17, 2026 •

edited

Loading

Karakatiza666 Apr 17, 2026 •

edited

Loading