[SQL] Test checking that CASE evaluation is lazy by mihaibudiu · Pull Request #6053 · feldera/feldera · GitHub
Skip to content

[SQL] Test checking that CASE evaluation is lazy#6053

Merged
mihaibudiu merged 1 commit intofeldera:mainfrom
mihaibudiu:issue6036
Apr 17, 2026
Merged

[SQL] Test checking that CASE evaluation is lazy#6053
mihaibudiu merged 1 commit intofeldera:mainfrom
mihaibudiu:issue6036

Conversation

@mihaibudiu
Copy link
Copy Markdown
Contributor

@mihaibudiu mihaibudiu commented Apr 16, 2026

Fixes #6036

This adds a test that validates that an expression like CASE WHEN x THEN y only evaluates y when x is true.
The test would panic with division by 0 if this wasn't true.

Signed-off-by: Mihai Budiu <mbudiu@feldera.com>
@mihaibudiu mihaibudiu enabled auto-merge April 16, 2026 01:56
@mihaibudiu mihaibudiu requested a review from gz April 16, 2026 01:56
Copy link
Copy Markdown

@mythical-fred mythical-fred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@gz gz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like a more specific file name would be nice

WhatFailedTest.java

@mihaibudiu mihaibudiu added this pull request to the merge queue Apr 16, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Apr 17, 2026
@mihaibudiu mihaibudiu added this pull request to the merge queue Apr 17, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Apr 17, 2026
@mihaibudiu mihaibudiu added this pull request to the merge queue Apr 17, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Apr 17, 2026
@gz gz added this pull request to the merge queue Apr 17, 2026
@gz gz removed this pull request from the merge queue due to a manual request Apr 17, 2026
@gz gz added this pull request to the merge queue Apr 17, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Apr 17, 2026
@mihaibudiu mihaibudiu added this pull request to the merge queue Apr 17, 2026
Merged via the queue into feldera:main with commit c98354c Apr 17, 2026
1 check passed
@mihaibudiu mihaibudiu deleted the issue6036 branch April 17, 2026 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[SQL] Check that CASE expressions are evaluated lazily

3 participants