{{ message }}
Conversation
Member
Author
Member
Author
|
Twitter:
Facebook:
Ignore the IP address, that was my testing DO droplet. |
Enable pretty Twitter and FB formatting. Add new image for sharing (fedoralovespython-share.jpg) only JPEG images are allowed Add metadata for FB and twitter validated with https://cards-dev.twitter.com/validator (Twitter) and https://developers.facebook.com/tools/debug/og/object/ Facebook validator shows some warnings which can be ignored: http://stackoverflow.com/questions/16475336/open-graph-twitter-cards-html5-incompatible Related issue: fedora-python#25
Member
|
I'd suggest smaller margin in the image. Like this (don't use this one, it's not cropped with any precision).
|
- smaller margins
Member
Author
Done. Twitter screenshot:
Facebook still has old one cached, will update asap. Can squash into one commit. |
Member
|
Could you plese do a deploy as described in https://github.com/fedora-python/fedoralovespython.org#hacking ? If there is anything unclear about it, ask and I'll update the instructions. |
hroncok
reviewed
Feb 22, 2017
| <!-- For Facebook and Twitter: --> | ||
| <meta property="og:type" content="article"> | ||
| <meta property="og:title" content="Fedora Loves Python - fedoralovespython.org"> | ||
| <meta property="og:description" content="Fedora’s relationship with Python is very close, making it probably the best platform for developing with Python - learn why!"> |
Member
There was a problem hiding this comment.
I'd drop the probably - let us brag a little.
hroncok
reviewed
Feb 22, 2017
| <link href='https://fonts.googleapis.com/css?family=Open+Sans:400,400italic,600,600italic&subset=latin' rel='stylesheet' type='text/css'> | ||
| <!-- For Facebook and Twitter: --> | ||
| <meta property="og:type" content="article"> | ||
| <meta property="og:title" content="Fedora Loves Python - fedoralovespython.org"> |
hroncok
reviewed
Feb 22, 2017
| <meta property="og:type" content="article"> | ||
| <meta property="og:title" content="Fedora Loves Python - fedoralovespython.org"> | ||
| <meta property="og:description" content="Fedora’s relationship with Python is very close, making it probably the best platform for developing with Python - learn why!"> | ||
| <meta property="og:url" content="https://fedoralovespython.org/"> |
Member
There was a problem hiding this comment.
Shouldn't this be the pages's url? There's also /__future__/
hroncok
reviewed
Mar 3, 2017
| <meta property="og:type" content="article"> | ||
| <meta property="og:title" content="Fedora Loves Python – fedoralovespython.org"> | ||
| <meta property="og:description" content="Fedora’s relationship with Python is very close, making it the best platform for developing with Python - learn why!"> | ||
| <meta property="og:url" content="https://fedoralovespython.org/"> |
Member
There was a problem hiding this comment.
This shall be with __future__ on the __future__ page
Member
|
@nmilosev what's the status? |
Member
Author
hroncok
marked this pull request as draft
May 13, 2021 12:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable pretty Twitter and FB formatting.
Add new image for sharing (fedoralovespython-share.jpg)
Add metadata for FB and twitter
https://developers.facebook.com/tools/debug/og/object/
Facebook validator shows some warnings which can be ignored:
Related issue: #25