fix(feathers): Paginated<Result> for ServiceMethods.find by fratzinger · Pull Request #3223 · feathersjs/feathers · GitHub
Skip to content

fix(feathers): Paginated<Result> for ServiceMethods.find#3223

Open
fratzinger wants to merge 3 commits into
dovefrom
fix/ServiceMethods-find-paginated
Open

fix(feathers): Paginated<Result> for ServiceMethods.find#3223
fratzinger wants to merge 3 commits into
dovefrom
fix/ServiceMethods-find-paginated

Conversation

@fratzinger

Copy link
Copy Markdown
Member

The ReturnType of ServiceMethods['find'] was Promise<Result | Result[]>. The correct way is Promise<Paginated<Result> | Result[]>.

I also added it to ServiceOverloads.

@fratzinger

fratzinger commented Jun 22, 2023

Copy link
Copy Markdown
Member Author

@fratzinger fratzinger requested a review from daffl June 22, 2023 11:22
@daffl

daffl commented Oct 11, 2023

Copy link
Copy Markdown
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants