Feature: Add pen tool icon by ashygee · Pull Request #522 · feathericons/feather · GitHub
Skip to content

Feature: Add pen tool icon - #522

Merged
colebemis merged 3 commits into
masterfrom
add-pentool
Jan 29, 2019
Merged

colebemis merged 3 commits into
masterfrom
add-pentool

Conversation

@ashygee

@ashygee ashygee commented Jan 26, 2019

Copy link
Copy Markdown
Collaborator

screenshot 2019-01-26 14 47 23

Suggesting to add a pen tool icon to collection.

Request review @colebemis.

@codecov

codecov Bot commented Jan 26, 2019 •

Copy link
Copy Markdown

@colebemis

Copy link
Copy Markdown
Member

Looks good! I usually try to avoid using the "dot" if I can help it. What do you think of these options? Do you have a preference?
image

@ashygee

ashygee commented Jan 28, 2019

Copy link
Copy Markdown
Collaborator Author

@colebemis i like the first version you made. What would that look like with the nib widened a bit?

@colebemis

Copy link
Copy Markdown
Member

Which one do you like?
image

@ashygee

ashygee commented Jan 28, 2019

Copy link
Copy Markdown
Collaborator Author

@colebemis I think for Feather the first is the best choice. It keeps the angles and simplicity of the other icons.

@colebemis

Copy link
Copy Markdown
Member

Sweet. Let's roll with that one. The icon is in the Figma doc 👍

@ashygee
ashygee requested a review from colebemis January 29, 2019 04:12
@ashygee

ashygee commented Jan 29, 2019

Copy link
Copy Markdown
Collaborator Author

Comment thread src/tags.json Outdated
Co-Authored-By: ashygee <10384315+ashygee@users.noreply.github.com>

@colebemis colebemis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another great addition! Thanks 🎉

@colebemis
colebemis merged commit 0a130b7 into master Jan 29, 2019
@colebemis
colebemis deleted the add-pentool branch January 29, 2019 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants