{{ message }}
Repository navigation
Conversation
The date column was built from the local date and time with a literal Z appended, so on any non-UTC system it disagreed with the timestamp column (UTC+02:00 gave 2024-01-01T02:00:00Z for timestamp 1704067200). Convert to UTC before formatting. Fixes feather-wallet#312
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #312
The history CSV export builds the
datecolumn from the local date and time and then tacks a literalZon the end. On any machine that isn't set to UTC,datedisagrees with thetimestampcolumn next to it. For timestamp 1704067200 on a UTC+02:00 machine it writes2024-01-01T02:00:00Zinstead of2024-01-01T00:00:00Z.This builds the string with
tx.timestamp.toUTC().toString(Qt::ISODate)instead, the line skaravos suggested in #312. It gives the sameYYYY-MM-DDTHH:MM:SSZshape as before, just actually in UTC.I checked the old and new expressions in a small Qt 6 program with
QDateTime::fromSecsSinceEpoch(1704067200):I did not build the full Feather tree here (the monero submodule isn't checked out on my machine), so the dialog itself is untested.
The min/max date filter in the same function still compares local dates, which is what the date pickers show, so I left it alone.
TransactionRow::date()andtime()have no other callers after this, I left them in to keep the diff to one line.One thing to be aware of: anyone who already parses the old CSV and strips the
Zwill see their times shift by their UTC offset, since the old values were local.