PasswordChangeDialog: make OK the default button by deepkv · Pull Request #311 · feather-wallet/feather · GitHub
Skip to content

PasswordChangeDialog: make OK the default button - #311

Open
deepkv wants to merge 1 commit into
feather-wallet:masterfrom
deepkv:fix/password-dialog-enter
Open

deepkv wants to merge 1 commit into
feather-wallet:masterfrom
deepkv:fix/password-dialog-enter

Conversation

@deepkv

@deepkv deepkv commented Sep 28, 2026

Copy link
Copy Markdown

Why

Pressing Enter in the password dialog closes it without changing the password and without any message. The dialog has no default button, so Qt makes Cancel (the first button in the focus chain) the default, and Enter clicks it.

What

Sets default on btn_OK in PasswordChangeDialog.ui, as QrCodeDialog.ui and VerifyProofDialog.ui already do for their buttons.

Enter pressed in a password field Before After
New passwords match Cancel: dialog closes, password unchanged OK: password is changed
New passwords differ Cancel: dialog closes Nothing: OK is disabled, dialog stays open

How to check

Click the lock icon in the status bar, fill in the fields, press Enter. "Password changed successfully" appears.

Pressing Enter in a password field clicked Cancel, closing the dialog
without changing the password.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant