{{ message }}
Repository navigation
Conversation
JuanVqz
force-pushed
the
add_gemfile_next_support
branch
4 times, most recently
from
March 22, 2024 14:36
0d0870b to
0a7c7fc
Compare
Member
Author
|
@stoem, awesome! anything you find please feel free to report it. |
|
@JuanVqz Could you briefly explain what the issue was and how you've solved it? Note I am not clued up on buildpacks. |
Member
Author
|
@stoem sure! The issue was that somehow after the Therefore, we decided that a better solution would be to implement the |
Closes #1
JuanVqz
force-pushed
the
add_gemfile_next_support
branch
from
May 24, 2024 13:25
0a7c7fc to
fccc116
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Closes #1
We can run the next Rails version in Heroku
IMPORTANT NOTES:
How are we going to manage this change in the long term? When the people at Heroku release new changes we are going to miss them out, is it better to keep our changes in a branch and rebase their changes as time passes? For sure, it would be better if we propose these changes to the official build pack and get merged 🤞
Switching between the current and next Rails versions in the same Heroku instance is not straightforward, we should run a purge or clean command to remove previously used gems and not fall on an issue. But why do we need to switch between them? is that our main reason for supporting Gemfile.next? I don't think so.
Even without these changes some tests were failing locally, it might be because of a misconfiguration, I wonder if we should make those tests pass and add more tests with the new implementation.
QA NOTES:
Select a project that already has the dual-boot configured and running.
In Heroku, go to the settings

Remove the official
heroku/rubybuild pack and include our build packhttps://github.com/fastruby/heroku-buildpack-ruby#add_gemfile_next_supportNotice that right now we are using this branch to test the changes.
BUNDLE_GEMFILEas a key andGemfile.nextas a value, then click add.Make sure Heroku picks the value you set in the config vars sometimes this takes some time.
heroku run bash --app your_app_nameto get into the bash in Heroku.then run the
rails --version,rails console,echo $BUNDLE_GEMFILEor any other command that helps you know you are using the next Rails version.