{{ message }}
Improvements to GUI selection and Qt support#431
Merged
kushalkolar merged 9 commits intofastplotlib:mainfrom Mar 31, 2024
Merged
Improvements to GUI selection and Qt support#431kushalkolar merged 9 commits intofastplotlib:mainfrom
kushalkolar merged 9 commits intofastplotlib:mainfrom
Conversation
Collaborator
Author
Merged
kushalkolar
requested changes
Mar 13, 2024
kushalkolar
reviewed
Mar 13, 2024
Collaborator
Author
|
Funny how pygfx/pygfx#674 gets reported while we're working on this 😄 I think I'll put this PR on hold, and first address the GUI backend selection mechanics. I think your code to check what GUI Jupyter has integrated should be used in wgpu-py. And perhaps it makes sense to provide more ways to influence backend preference, that fpl can then use (in the new |
Member
|
yup makes sense to do it upstream, less wheel reinventing 😄 |
Closed
Member
|
After pygfx/wgpu-py#478 it should be possible to greatly simplify this |
Collaborator
Author
|
I made some updates to make it work with the latest wgpu. Ready from my end! |
Member
clewis7
approved these changes
Mar 30, 2024
kushalkolar
approved these changes
Mar 31, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #384
fpl.utils/guimodule where the GUI selection is handled and nothing else.wgpu.gui.autoexcept infpl.utils.gui.fpl.run()method now matches the GUI backend in use (this was not necessarily the case previously).ipywidgetsis imported is now conditional (only happens in Jupyter notebook / lab).Note on performance: The import time is about 0.2 s faster on desktop (because it does not import Jupyter stuff). In the notebook we can expect a similar improvement because glfw and qt are not imported by default (when available).