{{ message }}
📝 Fix out-of-range highlight in advanced settings docs#15811
Open
patrickwehbe wants to merge 1 commit into
Open
📝 Fix out-of-range highlight in advanced settings docs#15811patrickwehbe wants to merge 1 commit into
patrickwehbe wants to merge 1 commit into
Conversation
The config.py embed used hl[10] but the file is only 7 lines long, so it highlighted a non-existent line. It was a leftover from the app01 example where line 10 was `settings = Settings()`. The prose just below confirms it: "Notice that now we don't create a default instance `settings = Settings()`."
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
docs/en/docs/advanced/settings.md, the config file embed useshl[10]:But
docs_src/settings/app02_an_py310/config.pyis only 7 lines long, sohl[10]highlights a line that does not exist.This looks like a leftover from the earlier app01 example, where line 10 was
settings = Settings(). The prose right below the embed confirms there is no such line here:This PR removes the
hl[10]so nothing out of range is highlighted.