{{ message }}
This repository was archived by the owner on Jan 13, 2022. It is now read-only.
Enable passing of and arguments in pipeline compiler#34
Open
pipermerriam wants to merge 2 commits into
Open
Conversation
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Author
ghost
added
the
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong?
The pipeline compiler did not have a hook to allow specifying the
harmonyorstrip_tagsflags into the call to the transformer.How was it fixed.
Pull the values off of the pipeline settings object if present, otherwise default to
Falsefor both arguments.This should work with any version of
pipeline>=1.3Cute animal picture