{{ message }}
Adds node nickname functionality#11
Merged
Merged
Conversation
…ing-in-node-ui Fix nickname overlapping
Author
Author
|
It is important to note that an example of the nickname behavior (which would be used after in the paceholder's pr) was not made, as the whole structure of the nickname is made in outside layers of code, and the current example nodes (calculator) are good examples already. |
tatatupi
requested changes
Sep 11, 2025
tatatupi
left a comment
tatatupi
left a comment
There was a problem hiding this comment.
There is examples missing. Perhaps implement it in the Calculator example, at the very least.
|
|
||
| virtual QRect resizeHandleRect(NodeId const nodeId) const = 0; | ||
|
|
||
| virtual int getPortSpasing() = 0; |
There was a problem hiding this comment.
Lacks documentation. Especially being a pure virtual method. And I guess there is a typo
Did you mean spacing?
EDIT: _spacing was already being used and had been implemented by other developers. However, I am still unclear about the usage of this method.
Gabrielnmds
requested changes
Dec 9, 2025
Gabrielnmds
approved these changes
Dec 10, 2025
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the nickname feature that was present in nodeeditor V1. Now, it is updated to seamlessly adapt to nodeeditor V3. A nickname changing feature via node UI is also included in the changes.