{{ message }}
changed the hashing algorithm from sha1 to sha256 due to security problems#990
Open
lucianidev wants to merge 1 commit intoexpressjs:masterfrom
Open
changed the hashing algorithm from sha1 to sha256 due to security problems#990lucianidev wants to merge 1 commit intoexpressjs:masterfrom
lucianidev wants to merge 1 commit intoexpressjs:masterfrom
Conversation
Member
|
Hello team, is this going to be addressed at some point soon? |
Member
|
One option would be to allow the user to choose which hashing algorithm to use |
Member
This was referenced Apr 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hello,
in the issue #989 the user references a vulnerability in the hashing algorithm sha1. The hashing method resulted vulnerable to hash collision, making it insecure. I changed the hashing method from sha1 to sha256 making it more secure. Tell me about any problems.
I hope you have a good day
Documentation:
https://crypto.stackexchange.com/questions/48289/how-secure-is-sha1-what-are-the-chances-of-a-real-exploit
https://www.quora.com/How-secure-is-SHA1-What-are-the-chances-of-a-real-exploit
https://stackoverflow.com/questions/38038841/why-is-sha-1-considered-insecure