{{ message }}
fix: replace deprecated asyncio.get_event_loop() with get_running_loop() in poll_until_finished - #205
Open
Shraman123 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What this PR fixes
In
exa_py/research/async_client.py,poll_until_finishedusesasyncio.get_event_loop().time()to track elapsed time.asyncio.get_event_loop()is deprecated since Python 3.10 when called inside a coroutine. Using it inside anasyncfunction emits a DeprecationWarning and may raise a RuntimeError in future Python versions.The correct replacement when already inside a running async context is
asyncio.get_running_loop().Changes
async_client.py: replaced 2 occurrences ofasyncio.get_event_loop().time()withasyncio.get_running_loop().time()inside thepoll_until_finishedcoroutineReferences
get_event_loop()in running loops