{{ message }}
Repository navigation
Apply NetBSD pkgsrc patch - #1020
Merged
Merged
Conversation
This was referenced Feb 14, 2025
StantonMatt
reviewed
Jun 2, 2026
StantonMatt
left a comment
StantonMatt
left a comment
There was a problem hiding this comment.
I checked the C++ hunk against the NetBSD pkgsrc patch for ruby-eventmachine, and it matches the intended kqueue guard: keep <sys/param.h> for __NetBSD__ and only use the NOTE_EOF fflags form before NetBSD 9.99.15.
On macOS arm64 with Ruby 3.3.11, this branch compiled cleanly for me with bundle exec rake compile, and bundle exec ruby -Ilib -Itests tests/test_send_file.rb passed with 7 tests / 7 assertions. I can't exercise the NetBSD path from here, and the PR currently reports no hosted checks, but the local compile/send_file smoke looks good from my side.
nevans
force-pushed
the
netbsd-patch
branch
2 times, most recently
from
July 7, 2026 19:12
e561830 to
95b5ea4
Compare
Contributor
Author
Copied the patch from NetBSD's pkgsrc, commit d85ec4a9d devel/ruby-eventmachine/patches/patch-ext_em.cpp Co-authored-by: ryoon <ryoon@pkgsrc.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At @drixter's suggestion (#1014), I've copied the patch from NetBSD's pkgsrc, commit d85ec4a9d
devel/ruby-eventmachine/patches/patch-ext_em.cpp.
This is based on #1018 (rebased on 2026-07-07 on #1028, #1029), so the build will pass (maybe?).