Change registerScript method to registerJsFile method in EmbedService. by RedLucas · Pull Request #341 · ethercreative/simplemap · GitHub
Skip to content

Change registerScript method to registerJsFile method in EmbedService. - #341

Merged
Tam merged 1 commit into
ethercreative:v3-devfrom
RedLucas:issue-340-register-script
Jul 11, 2022
Merged

Change registerScript method to registerJsFile method in EmbedService.#341
Tam merged 1 commit into
ethercreative:v3-devfrom
RedLucas:issue-340-register-script

Conversation

@RedLucas

Copy link
Copy Markdown

Fixes #340 .

Changes proposed in this pull request:

  • Updating the registerScript method to be a registerJsFile method to avoid error on template cached maps.

@RedLucas

Copy link
Copy Markdown
Author

@RedLucas

RedLucas commented Jul 8, 2022

Copy link
Copy Markdown
Author

@Tam
Tam changed the base branch from v3 to v3-dev July 11, 2022 10:09
@Tam
Tam merged commit b36616d into ethercreative:v3-dev Jul 11, 2022
@Tam Tam mentioned this pull request Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mapbox integration within {% cache %} template tags causes "Undefined key 0" from TemplatesCache.php

2 participants