On Dec 16, 2022, 14:44, david gauchard wrote: @d-a-v commented on this pull request. --------------------------------------------------------------- In [libraries/ESP8266WiFi/src/ESP8266WiFiAP.h](#8695 (comment)): > @@ -37,8 +37,8 @@ class ESP8266WiFiAPClass { public: - bool softAP(const char* ssid, const char* psk = NULL, int channel = 1, int ssid_hidden = 0, int max_connection = 4); - bool softAP(const String& ssid,const String& psk = emptyString,int channel = 1,int ssid_hidden = 0,int max_connection = 4); + bool softAP(const char* ssid, const char* psk = NULL, int channel = 1, int ssid_hidden = 0, int max_connection = 4, int beacon_interval = 100); + bool softAP(const String& ssid,const String& psk = emptyString,int channel = 1,int ssid_hidden = 0,int max_connection = 4,int beacon_interval = 100); I don't know if I was clear and sorry for that. I meant it is preferable to do this, in case of subclassing / overloading. bool softAP ( const char * ssid, const char * psk = NULL , int channel = 1 , int ssid_hidden = 0 , int max_connection = 4 ) { return softAP (ssid, psk, channel, hidden, max_connection, 100 ); } + bool softAP ( const char * ssid, const char * psk, int channel, int ssid_hidden, int max_connection, int beacon_interval); — Reply to this email directly, [view it on GitHub](#8695 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/ASY4EOBUMNUDK6L6GACZIILWNRW2BANCNFSM6AAAAAARJHJK2E). You are receiving this because you authored the thread.Message ID: ***@***.***>

On Dec 17, 2022, 11:09, Max Prokhorov wrote: @mcspr commented on this pull request. --------------------------------------------------------------- In [libraries/ESP8266WiFi/src/ESP8266WiFiAP.h](#8695 (comment)): > @@ -37,8 +37,8 @@ class ESP8266WiFiAPClass { public: - bool softAP(const char* ssid, const char* psk = NULL, int channel = 1, int ssid_hidden = 0, int max_connection = 4); - bool softAP(const String& ssid,const String& psk = emptyString,int channel = 1,int ssid_hidden = 0,int max_connection = 4); + bool softAP(const char* ssid, const char* psk = NULL, int channel = 1, int ssid_hidden = 0, int max_connection = 4, int beacon_interval = 100); + bool softAP(const String& ssid,const String& psk = emptyString,int channel = 1,int ssid_hidden = 0,int max_connection = 4,int beacon_interval = 100); I don't believe this matters in our case too too much? Ambiguous overload is resolved at build time, everything is ok on that part. If we worry about faulty default method used, arguments are expanded left-to-right so user will magically use the new method after upgrading our version. If we worry about binary stability and preserving existing function signature in the .o file... idk how does one need to build its software for it to matter :) — Reply to this email directly, [view it on GitHub](#8695 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/ASY4EOFHCOLD2BG6GAULEFDWNWGMHANCNFSM6AAAAAARJHJK2E). You are receiving this because you authored the thread.Message ID: ***@***.***>