{{ message }}
MOD-WIFI-ESP8266(-DEV) update#8297
Merged
Merged
Conversation
Added Flash mode and reset method selection options for Olimex board MOD-WIFI-ESP8266(-DEV)
earlephilhower
requested changes
Sep 1, 2021
earlephilhower
left a comment
earlephilhower
left a comment
Collaborator
There was a problem hiding this comment.
This isn't going to pass CI. You need to update tools/boards.txt.py and regenerate the boards.txt file from it,, not manually edit boards.txt.
Plus, it seems like you're doing both normal definitions and menu overridden ones which is not correct. See line 5832-5833 and 5849-5850.
The addition of the FlashMode and ResetMethod selection options via boards.txt.py generation file.
Contributor
Author
d-a-v
approved these changes
Sep 21, 2021
hasenradball
pushed a commit
to hasenradball/Arduino
that referenced
this pull request
Nov 18, 2024
Added Flash mode and reset method selection options for Olimex board MOD-WIFI-ESP8266(-DEV) The addition of the FlashMode and ResetMethod selection options via boards.txt.py generation file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added Flash mode and reset method selection options for Olimex board MOD-WIFI-ESP8266(-DEV)