Clean up use of "byte" as a type. uint8_t or (C++17) std::byte are better by dok-net · Pull Request #8090 · esp8266/Arduino · GitHub
Skip to content

Clean up use of "byte" as a type. uint8_t or (C++17) std::byte are better#8090

Merged
d-a-v merged 2 commits into
esp8266:masterfrom
dok-net:fix_8089
Jul 26, 2021
Merged

Clean up use of "byte" as a type. uint8_t or (C++17) std::byte are better#8090
d-a-v merged 2 commits into
esp8266:masterfrom
dok-net:fix_8089

Conversation

@dok-net

@dok-net dok-net commented May 31, 2021

Copy link
Copy Markdown
Contributor

Related to #8089

@earlephilhower earlephilhower left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a fan of the way Arduino did it, but this breaks Arduino compatibility.

https://github.com/arduino/ArduinoCore-API/blob/173e8eadced2ad32eeb93bcbd5c49f8d6a055ea6/api/Common.h#L151-L153

uint16_t makeWord(uint16_t w);
uint16_t makeWord(byte h, byte l);

Removing byte elsewhere seems fine, but the 2-param makeword seems like it should be moved from unsigned char to byte in WMath.cpp.

@dok-net

dok-net commented May 31, 2021

Copy link
Copy Markdown
Contributor Author

@dok-net dok-net requested a review from earlephilhower May 31, 2021 21:12
@dok-net dok-net force-pushed the fix_8089 branch 2 times, most recently from 1f3a19b to 8b48530 Compare June 3, 2021 16:43
@dok-net

dok-net commented Jun 3, 2021

Copy link
Copy Markdown
Contributor Author

@dok-net dok-net force-pushed the fix_8089 branch 3 times, most recently from a5b8112 to c00faa0 Compare June 8, 2021 01:46

@earlephilhower earlephilhower left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@earlephilhower earlephilhower added this to the 3.1 milestone Jun 17, 2021
@d-a-v d-a-v modified the milestones: 3.1, 3.0.2 Jul 19, 2021
@d-a-v d-a-v merged commit bc30251 into esp8266:master Jul 26, 2021
dperish added a commit to dperish/WiFiManager that referenced this pull request Sep 21, 2021
Change byte to uint8_t to cope with breaking change in 3.2.0 of platform:  esp8266/Arduino#8090
@dok-net dok-net deleted the fix_8089 branch October 9, 2021 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants