{{ message }}
Clean up use of "byte" as a type. uint8_t or (C++17) std::byte are better#8090
Merged
Conversation
earlephilhower
requested changes
May 31, 2021
earlephilhower
left a comment
Collaborator
There was a problem hiding this comment.
Not a fan of the way Arduino did it, but this breaks Arduino compatibility.
uint16_t makeWord(uint16_t w);
uint16_t makeWord(byte h, byte l);
Removing byte elsewhere seems fine, but the 2-param makeword seems like it should be moved from unsigned char to byte in WMath.cpp.
Contributor
Author
1f3a19b to
8b48530
Compare
Contributor
Author
a5b8112 to
c00faa0
Compare
d-a-v
approved these changes
Jul 11, 2021
dperish
added a commit
to dperish/WiFiManager
that referenced
this pull request
Sep 21, 2021
Change byte to uint8_t to cope with breaking change in 3.2.0 of platform: esp8266/Arduino#8090
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Related to #8089