{{ message }}
Don't overwrite boot sector unless OTA changes it#7547
Merged
Conversation
There is a window where the eboot sector is erased and unwritten/partially written. If there's a power cycle at this time, the chip will brick due to eboot being corrupted. Avoid this by checking if the new eboot 4K sector is identical to the one already in flash, and if so don't rewrite it.
Collaborator
|
Yes, we're merging for v3 these days. We'll get there. |
|
It's a two pronged query (though I hadn't realised it had an assigned
milestone).
Partly as this was one of the changes. that had been discussed to go into
#6538, and partly because I'm keen to get that PR merged, but it's going to
involve a bunch of changes from where it stands as the changes the PR
included when submitted now conflict with a small collection of more recent
changes (such as this PR would likely make).
Which probably boils down to looking for clarity on the order of things to
avoid having too many conflicts to resolve before #6538 can actually be
merged cleanly at all.
…On Wed, Sep 2, 2020 at 1:21 AM Develo ***@***.***> wrote:
Yes, we're merging for v3 these days. We'll get there.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#7547 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABX6A2INQR6GRFBNYADC4TSDTYL5ANCNFSM4QJAM4PQ>
.
|
Collaborator
Author
|
@davisonja, sorry, I actually thought #6538 was abandoned. If you want to integrate this boot-block check there, I'm happy to axe this PR. It should be orthogonal to your changes, though. Can you spend a few mins to make #6538 mergeable? It also has some issues w/the branch pulling in old versions of multiple libraries, so it's in kind of a weird state beyond just the code merge issues. |
Collaborator
Jason2866
added a commit
to Jason2866/Arduino
that referenced
this pull request
Sep 17, 2020
Jason2866
added a commit
to Jason2866/Arduino
that referenced
this pull request
Sep 17, 2020
Jason2866
added a commit
to Jason2866/Tasmota
that referenced
this pull request
Sep 17, 2020
core 2.7.4.2 includes some backports from arduino / master esp8266/Arduino#7547 esp8266/Arduino#7586 esp8266/Arduino#7585 esp8266/Arduino#7595
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a window where the eboot sector is erased and
unwritten/partially written. If there's a power cycle at this time, the
chip will brick due to eboot being corrupted.
Avoid this by checking if the new eboot 4K sector is identical to the
one already in flash, and if so don't rewrite it.