{{ message }}
Fixed PUYA flash write buffer alignment#7491
Merged
Merged
Conversation
d-a-v
approved these changes
Jul 29, 2020
earlephilhower
approved these changes
Jul 30, 2020
earlephilhower
left a comment
earlephilhower
left a comment
Collaborator
There was a problem hiding this comment.
Looks good, thanks! The rounding up to x4 is a little odd but I think it works fine.
devyte
approved these changes
Jul 30, 2020
Contributor
Author
|
Thanks for the observation @yumkam , must have missed this somehow. Another pull request is on the way. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This merge fixes flash writing on PUYA flashes when write size is not a multiple of 4.
This bug prevents updating via Arduino OTA when using gzipped image.