{{ message }}
Revamp of the FSBrowser and SDWebServer examples#7182
Merged
Conversation
LittleFS based on a #define logic (required adding a second param to open() and replacing 'FILE_WRITE' by "w") + Added size information to file list and a /status request handler to return filesystem status
…r and more neutral), including one for files. Show size of files. Fill "filename" box upon clicking on a file. Sort files alphabetically.
+ Massive cleanup/merge/align with some code from the FSBrowser example and misc refactorings
…ced FSConfig to prevent FS formating. Fixed recursive deletion. Got rid of specific isDir() for SPIFFS.
Refresh only part of the tree when possible. Selecting a file for upload defaults to the same folder as the last clicked file. Removed the Mkdir button on SPIFFS.
Slight refactoring of XMLHttpRequest completion handling
Case insensivity of the extension for the editor and preview.
Added Save/Discard/Help buttons to Editor, discard confirmation on leave, and refresh tree/status upon save. Removed redundant Ctrl-Z + Ctrl-Shift-Z shortcut declarations. Small bug fixes. + some refactoring
…path as response to the delete request. Refactoring
…tip. Unsupported files on SPIFFS (files at root not sarting with "/", files with double "/", files ending with "/") are now detected and reported in the page.
Added "loading" screen during async operations (dim with spinner and status). Fixed "discard" feature that kept prompting even after an image was loaded. Improved refresh of parts of the tree, with recursive listing. Moved the "path" id attribute to the "li" elements for folders (was already the case for files). Refactoring and cleanup.
Removed non-functional Upload context menu. Fixed error in response to move requests. Added minified version.
Fixed incompatibilities with SPIFFS. Fixed a race condition between deletion and reinsertion of nodes when multiple folders are refreshed. Fixed missing URL decoding for files with special chars (e.g. space char). Moved info from source code comment to a readme.md file. Added source PNG to git. Cleanup.
…pdate to index.htm.
devyte
requested changes
Apr 27, 2020
devyte
left a comment
devyte
left a comment
Collaborator
There was a problem hiding this comment.
This is rather close. Some replies to the unresolved conversations.
devyte
requested changes
Apr 28, 2020
…it when required.
Contributor
Author
Collaborator
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following a discussion in issue #7002 , I proposed to unify the versions (FSBrowser and SDWebServer) and make it a "universal" FS browser. I also tried to modernize calls (e.g. using SDFS instead of SD).
One thing leading to another, I ended up improving usability and adding many features, such as a file size, free space bargraph and rename/move features.
So this is kind of "FSBrowser on steroïds". Hope you'll like it.
Please don't hesitate to test and give feedback.
Here is the hi-level changelog :
Fixes to work on LittleFS based on SDFS
UI/usability improvements
Other