{{ message }}
Move floating point from libgcc out of IRAM#7180
Merged
Merged
Conversation
6 tasks
earlephilhower
requested changes
Apr 2, 2020
earlephilhower
left a comment
earlephilhower
left a comment
Collaborator
There was a problem hiding this comment.
Sorry, in the Arduino core it is legal to do FP operations inside ISRs so this can't be done generally.
If you invert the logic (i.e. #ifndef FP_IN_PMEM) so that the core/PIO users don't see code breaking, and your own project can add the #define since it's a limited scope, then it would be more acceptable.
Contributor
Author
earlephilhower
approved these changes
Apr 2, 2020
earlephilhower
left a comment
earlephilhower
left a comment
Collaborator
There was a problem hiding this comment.
My bad, sorry! I didn't catch which section was being edited.
d-a-v
approved these changes
Apr 3, 2020
|
How can I use it? using: framework-arduinoespressif8266 483bfde |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Tasmota I realized the following floating point function are in precious IRAM:
This PR adds a
#define FP_IN_IROMto move floating point function out of IRAM to IROM.*f2.o,*f3.o:floatanddoublefunctions*fsi.o: fp to int*fdi.o: fp to long*ifs.o: int to fp*ids.o: long to fpIn Tasmota, the only functions from
libgccremaining in IRAM are:__modsi3(integer modulus) and__ashrdi3(bit shifting).The net result is reducing IRAM usage by 1040 bytes.