{{ message }}
Fix/enable UDP packet reassembly#7036
Merged
Merged
Conversation
UdpContext didn't care about pbuf chaining when receiving datagrams, leading to fragments delivered to the application as individual packets.
d-a-v
added
component: network
good first issue
Implementation copied verbatim from LwIP 2.1.2
d-a-v
approved these changes
Jan 26, 2020
d-a-v
left a comment
d-a-v
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for fixing that (probably pending from the introduction of fragment/reassemble lwIP-v2 option).
You took the safe pbuf-logic way for lwip-1.4 (even if I think it does not have this option).
Out of curiosity, what was the UDP protocol which highlighted this bug ?
Contributor
Author
devyte
requested changes
Feb 18, 2020
devyte
approved these changes
Feb 22, 2020
6 tasks
This was referenced Mar 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UdpContext didn't care about pbuf chaining when receiving datagrams, leading
to fragments delivered to the application as individual packets.