{{ message }}
Code changes for issue #6465: SPIFFS name()/fullName()#6522
Closed
ewaldc wants to merge 0 commit into
Closed
Conversation
devyte
approved these changes
Sep 15, 2019
devyte
left a comment
devyte
left a comment
Collaborator
There was a problem hiding this comment.
Seems simple enough. Targeted for 3.0.0.
devyte
added
type: enhancement
component: libraries
component: core
and removed
component: libraries
labels
earlephilhower
approved these changes
Sep 17, 2019
earlephilhower
left a comment
earlephilhower
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, straightforward but breaking so 3.0.0 it is...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
code from fname() becomes fullName()
name() now returns the file name (path name is stripped off), as per SPIFFS/LittleFS documentation
Fixes #6465