{{ message }}
fix: Allow callers to request access to the underlying display controller, and add back write_lcd_lines APIs to the components#631
Merged
Conversation
…ller, and add back write_lcd_lines APIs to the components
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates multiple display-capable BSP components to expose access to the underlying display controller object and reintroduces a legacy write_lcd_lines(...) API for scanline/region-oriented LCD writes.
Changes:
- Switch BSP-held display controller ownership from
std::unique_ptrtostd::shared_ptrso callers can obtain a handle via a newdisplay_driver()accessor. - Add/restore
write_lcd_lines(...)helper APIs across several BSPs for partial-region LCD writes. - Add minor supporting includes/aliases where needed to support the new APIs.
Reviewed changes
Copilot reviewed 24 out of 24 changed files in this pull request and generated 10 comments.
Show a summary per file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
write_lcd_linesto update just a portion of the display, rather than a full frame.Motivation and Context
These APIs are useful, and are currently used in the esp-cpp/camera-display example to efficiently update the screen with decoded image data from an RTSP stream without needing to have larger / additional buffers.
How has this been tested?
Build and run the esp-box example.
Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):
Types of changes
Checklist:
Software
.github/workflows/build.ymlfile to add my new test to the automated cloud build github action.