fix(doom): Fix music not playing on subsequent plays and memory leaks / issues between launches by finger563 · Pull Request #114 · esp-cpp/esp-box-emu · GitHub
Skip to content

fix(doom): Fix music not playing on subsequent plays and memory leaks / issues between launches#114

Merged
finger563 merged 1 commit into
mainfrom
fix/doom-memory-leak
Jun 23, 2026
Merged

fix(doom): Fix music not playing on subsequent plays and memory leaks / issues between launches#114
finger563 merged 1 commit into
mainfrom
fix/doom-memory-leak

Conversation

@finger563

@finger563 finger563 commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Description

Motivation and Context

How has this been tested?

Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Hardware (schematic, board, system design) change
  • Software change

Checklist:

  • My change requires a change to the documentation.
  • I have added / updated the documentation related to this change via either README or WIKI

Software

  • I have added tests to cover my changes.
  • I have updated the .github/workflows/build.yml file to add my new test to the automated cloud build github action.
  • All new and existing tests passed.
  • My code follows the code style of this project.

Hardware

  • I have updated the design files (schematic, board, libraries).
  • I have attached the PDFs of the SCH / BRD to this PR
  • I have updated the design output (GERBER, BOM) files.

@finger563
fix remaining issues with doom; ensure music plays on subsequent laun…
26fe356 
…ches; ensure different doom titles can be launched back to back many times without crash or memory pressure
@github-actions

github-actions Bot commented Jun 23, 2026

Copy link
Copy Markdown

@finger563 finger563 self-assigned this Jun 23, 2026
@finger563 finger563 added bug Something isn't working doom labels Jun 23, 2026
@github-actions

github-actions Bot commented Jun 23, 2026

Copy link
Copy Markdown

ESP-IDF Size Report for 'Esp Box Emu'

Metric Base PR Delta
FLASH 3,138,304 bytes (49.88%) 3,138,728 bytes (49.89%) 🔺 +424 bytes (+0.01%)
DRAM 179,195 bytes (52.43%) 179,195 bytes (52.43%) 0 bytes (0.00%)
IRAM 0 bytes 0 bytes 0 bytes
RAM (DRAM+IRAM) 179,195 bytes 179,195 bytes 0 bytes (0.00%)

FLASH uses app .bin size or json2 flash sum. RAM sums DRAM+IRAM via idf_size. Percentages shown when totals are available.
DRAM/IRAM usage does not include memory used by the heap allocator at runtime.
This report was generated by esp-idf-size-delta.

@finger563 finger563 merged commit 11f6569 into main Jun 23, 2026
3 checks passed
@finger563 finger563 deleted the fix/doom-memory-leak branch June 23, 2026 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@finger563 finger563

Labels

bug Something isn't working doom

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@finger563