{{ message }}
Grammar-driven binary operator precedence#174
Open
lightmare wants to merge 3 commits into
Open
Conversation
devsnek
reviewed
Aug 28, 2021
devsnek
left a comment
devsnek
left a comment
Member
There was a problem hiding this comment.
overall seems nice, just need to work out the chaining dispatch...
Member
Jack-Works
force-pushed
the
main
branch
9 times, most recently
from
707b116 to
0b90e51
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was motivated by a desire to experiment with new operators. The very first step in doing so — adding a token type for the new operator — is tedious. You have to pick a precedence level and then bump other operators. If you want to add a right-associative operator, you also need modify
parseBinaryExpression.So the first thing I did was multiply levels by 100, so that there are gaps for new operators (something I learned from Prolog).
But then I realized ECMAScript doesn't define operator precedence with numbers. It is embedded in the grammar. And I thought it'd be nice to have this reference implementation follow the grammar more closely.