{{ message }}
Merge params with existing URL query parameters instead of replacing#3761
Open
veeceey wants to merge 1 commit into
Open
Merge params with existing URL query parameters instead of replacing#3761veeceey wants to merge 1 commit into
veeceey wants to merge 1 commit into
Conversation
…them
When a URL already contains query parameters and the `params` argument is
also provided, the existing query parameters are now merged with the new
ones instead of being silently dropped. This aligns with the behavior of
the `requests` library and matches user expectations.
Fixes #3621
veeceey
force-pushed
the
fix/issue-3621
branch
from
58e14dd to
38fe19f
Compare
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
https://example.com/path?page=1&s=list) and theparamsargument is also provided, the existing query parameters were silently dropped and replaced by only the newparams. This was inconsistent with therequestslibrary and surprised users.Request.__init__to useURL(url).copy_merge_params(params)instead ofURL(url, params=params), so existing URL query parameters are preserved and merged with the new ones.test_request_paramsto reflect the new merge behavior and added an additional test case for overlapping keys.Before (broken)
After (fixed)
Test plan
test_request_paramsupdated and passes