{{ message }}
Fix support for connection Upgrade and CONNECT when some data in the stream has been read.#882
Merged
Merged
Conversation
Contributor
Author
Contributor
|
Ah fantastic thanks, shall we start with a test?...
httpcore/tests/_async/test_http11.py Line 238 in 79fa6bf I think the next step after that will be...
And then...
|
Contributor
Author
|
Thank you for your guidance 🙏 I'll give it a try. |
Contributor
Author
|
Work completed, I marked PR as ready. Could you please review this?
|
lovelydinosaur
left a comment
Contributor
There was a problem hiding this comment.
This one is a fantastic fix, thanks. ✨
Minor suggestion wrt. the tests.
Later follow-ups we can consider...
- Should all HTTP requests include this behaviour or only
Upgrade/CONNECT? - Should all HTTP requests return
network_streamor onlyUpgrade/CONNECT? - What might a nice
__repr__be here?
(I'm just jotting these down here for reference)
T-256
reviewed
Feb 14, 2024
Upgrade and CONNECT.Co-authored-by: Tom Christie <tom@tomchristie.com>
Co-authored-by: T-256 <132141463+T-256@users.noreply.github.com>
lovelydinosaur
approved these changes
Feb 20, 2024
Contributor
|
Nice work. |
Contributor
Author
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
UpgradeandCONNECT. #872Checklist