{{ message }}
This repository was archived by the owner on Apr 6, 2026. It is now read-only.
Repository navigation
Give more specific errors when rcedit cannot set an icon - #74
Merged
Merged
Conversation
ckerr
suggested changes
May 2, 2018
ckerr
left a comment
ckerr
left a comment
Member
There was a problem hiding this comment.
LOG(ERROR) << ... would be the more idiomatic way to do this in Electron's source.
Other than that, LGTM. Thanks for the patch!
Member
Member
Author
|
I'd be happy to use a more idiomatic way to deal with errors, but my knowledge of the C++/Windows ecosystem is minimal, so assistance would be much appreciated. |
This was referenced May 3, 2018
zcbenz
approved these changes
May 7, 2018
zcbenz
left a comment
zcbenz
left a comment
Contributor
There was a problem hiding this comment.
For this tiny project fprintf looks good enough, currently it does not have LOG(ERROR) which is a thing from Chromium.
Member
Author
|
Thanks @zcbenz. When can we expect a new release of |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the Electron Packager and Electron Forge issue trackers, one of the common issues that pops up is people asking what's going on when the build process errors out with
rcedit.exe failed with exit code 1. Fatal error: Unable to set icon. This pull request attempts to give more details as to why setting the icon failed.