docs: protocol api: simplification by dsanders11 · Pull Request #368 · electron/governance · GitHub
Skip to content

docs: protocol api: simplification - #368

Closed
dsanders11 wants to merge 1 commit into
electron:mainfrom
dsanders11:protocol-api-simplification
Closed

dsanders11 wants to merge 1 commit into
electron:mainfrom
dsanders11:protocol-api-simplification

Conversation

@dsanders11

@dsanders11 dsanders11 commented Nov 2, 2020 •

Copy link
Copy Markdown
Member

Simplification of the protocol module APIs.

Expose protocol.registerProtocol and protocol.interceptProtocol to allow any type of protocol response, simplifying the API surface of the protocol module. Add several classes to replace the overloaded ProtocolResponse object. Deprecate the current protocol.{intercept|register}{Buffer|File|Http|Stream|String}Protocol methods.

Rendered markdown.

@dsanders11
dsanders11 requested a review from a team as a code owner November 2, 2020 07:59
@nornagon

nornagon commented Dec 6, 2022

Copy link
Copy Markdown
Contributor

@samuelmaddock

Copy link
Copy Markdown
Member

@nornagon has this design landed?

@dsanders11

Copy link
Copy Markdown
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants